Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GRS attributes to pi_volume (d) and pi_instance_volumes (d) #149

Closed
wants to merge 14 commits into from

Conversation

Alexander-Kita
Copy link
Collaborator

@Alexander-Kita Alexander-Kita commented Aug 6, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_volume (d):

=== RUN   TestAccIBMPIVolumeDataSource_basic
--- PASS: TestAccIBMPIVolumeDataSource_basic (6.67s)
PASS
=== RUN   TestAccIBMPIVolumeDataSource_replication
--- PASS: TestAccIBMPIVolumeDataSource_replication (11.99s)
PASS

pi_instance_volumes (d):

=== RUN   TestAccIBMPIVolumesDataSource_basic
--- PASS: TestAccIBMPIVolumesDataSource_basic (18.04s)
PASS

Description:

Added replication_sites, creation_date, last_update_date, and freeze_time attributes to pi_instance_volumes and pi_volume data sources.

Added replication_enabled attribute to volumes returned by pi_instance_volumes data source.

@Alexander-Kita Alexander-Kita changed the title Add gsr attributes volume d Add GRS attributes volume d Aug 6, 2024
@Alexander-Kita Alexander-Kita changed the title Add GRS attributes volume d Add GRS attributes to pi_volume (d) and pi_instance_volumes (d) Aug 6, 2024
@Alexander-Kita Alexander-Kita marked this pull request as ready for review August 7, 2024 16:55
@Alexander-Kita Alexander-Kita self-assigned this Aug 7, 2024
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

ibm/service/power/data_source_ibm_pi_volume.go Outdated Show resolved Hide resolved
website/docs/d/pi_volume.html.markdown Outdated Show resolved Hide resolved
website/docs/d/pi_instance_volumes.html.markdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Alexander-Kita
Copy link
Collaborator Author

Opened in main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants