forked from IBM-Cloud/terraform-provider-ibm
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GRS attributes to pi_volume (d) and pi_instance_volumes (d) #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Kita
changed the title
Add gsr attributes volume d
Add GRS attributes volume d
Aug 6, 2024
Alexander-Kita
changed the title
Add GRS attributes volume d
Add GRS attributes to pi_volume (d) and pi_instance_volumes (d)
Aug 6, 2024
ismirlia
reviewed
Aug 8, 2024
michaelkad
reviewed
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments
ismirlia
approved these changes
Aug 26, 2024
michaelkad
reviewed
Aug 26, 2024
michaelkad
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Alexander-Kita
force-pushed
the
add-gsr-attributes-volume-d
branch
from
September 19, 2024 17:09
10f41fd
to
5a4fb5e
Compare
… instance volume data source
Co-authored-by: michaelkad <45772690+michaelkad@users.noreply.github.com>
Alexander-Kita
force-pushed
the
add-gsr-attributes-volume-d
branch
from
September 23, 2024 16:07
5a4fb5e
to
76f1325
Compare
Opened in main repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing:
pi_volume (d):
pi_instance_volumes (d):
Description:
Added replication_sites, creation_date, last_update_date, and freeze_time attributes to pi_instance_volumes and pi_volume data sources.
Added replication_enabled attribute to volumes returned by pi_instance_volumes data source.