Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replication_pool_map to disaster recovery data sources #147

Closed
wants to merge 5 commits into from

Conversation

Alexander-Kita
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_disaster_recovery_location:

=== RUN   TestAccIBMPIDisasterRecoveryLocationDataSourceBasic
--- PASS: TestAccIBMPIDisasterRecoveryLocationDataSourceBasic (5.74s)
PASS

pi_disaster_recovery_locations:

=== RUN   TestAccIBMPIDisasterRecoveryLocationsDataSourceBasic
--- PASS: TestAccIBMPIDisasterRecoveryLocationsDataSourceBasic (6.35s)
PASS

Description: Added replication_pool_map attribute to pi_disaster_recovery_location and pi_disaster_recovery_locations datasources.

@Alexander-Kita Alexander-Kita self-assigned this Aug 5, 2024
@Alexander-Kita Alexander-Kita marked this pull request as draft August 5, 2024 17:01
@Alexander-Kita Alexander-Kita marked this pull request as ready for review August 5, 2024 17:10
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left few comments that need to be addressed.

ibm/service/power/ibm_pi_constants.go Outdated Show resolved Hide resolved
ibm/service/power/ibm_pi_constants.go Outdated Show resolved Hide resolved
website/docs/d/pi_disaster_recovery_location.html.markdown Outdated Show resolved Hide resolved
website/docs/d/pi_disaster_recovery_location.html.markdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@michaelkad michaelkad added the Q3 label Sep 13, 2024
@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-disaster-recovery-d branch from fcaccb6 to 1a86e8b Compare September 19, 2024 17:55
@Alexander-Kita Alexander-Kita force-pushed the add-gsr-attributes-disaster-recovery-d branch from 1a86e8b to 8560ded Compare September 23, 2024 15:48
@Alexander-Kita
Copy link
Collaborator Author

Opened in main repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants