Skip to content

Commit

Permalink
[ARM] pxa: introduce reset_status and clear_reset_status for driver's…
Browse files Browse the repository at this point in the history
… usage

Due to the problem of reset status bits being handled by different
registers between pxa2xx and pxa3xx, introduce a global reset_status
variable, initialized by SoC-specific code and later being used by
other drivers.

And also introduce clear_reset_status(), which is used to clear the
corresponding status bits. Pass RESET_STATUS_ALL to clear all bits.

Signed-off-by: Eric Miao <eric.miao@marvell.com>
  • Loading branch information
Eric Miao committed Aug 5, 2008
1 parent ab27712 commit 04fef22
Show file tree
Hide file tree
Showing 10 changed files with 79 additions and 3 deletions.
10 changes: 10 additions & 0 deletions arch/arm/mach-pxa/generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,19 @@
#include <asm/mach/map.h>

#include <asm/arch/pxa-regs.h>
#include <asm/arch/reset.h>

#include "generic.h"

void clear_reset_status(unsigned int mask)
{
if (cpu_is_pxa2xx())
pxa2xx_clear_reset_status(mask);

if (cpu_is_pxa3xx())
pxa3xx_clear_reset_status(mask);
}

/*
* Get the clock frequency as reflected by CCCR and the turbo flag.
* We assume these values have been applied via a fcs.
Expand Down
8 changes: 8 additions & 0 deletions arch/arm/mach-pxa/generic.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,20 @@ extern unsigned pxa27x_get_memclk_frequency_10khz(void);
#define pxa27x_get_memclk_frequency_10khz() (0)
#endif

#if defined(CONFIG_PXA25x) || defined(CONFIG_PXA27x)
extern void pxa2xx_clear_reset_status(unsigned int);
#else
static inline void pxa2xx_clear_reset_status(unsigned int mask) {}
#endif

#ifdef CONFIG_PXA3xx
extern unsigned pxa3xx_get_clk_frequency_khz(int);
extern unsigned pxa3xx_get_memclk_frequency_10khz(void);
extern void pxa3xx_clear_reset_status(unsigned int);
#else
#define pxa3xx_get_clk_frequency_khz(x) (0)
#define pxa3xx_get_memclk_frequency_10khz() (0)
static inline void pxa3xx_clear_reset_status(unsigned int mask) {}
#endif

extern struct sysdev_class pxa_irq_sysclass;
Expand Down
4 changes: 4 additions & 0 deletions arch/arm/mach-pxa/pxa25x.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include <asm/arch/pxa-regs.h>
#include <asm/arch/pxa2xx-regs.h>
#include <asm/arch/mfp-pxa25x.h>
#include <asm/arch/reset.h>
#include <asm/arch/pm.h>
#include <asm/arch/dma.h>

Expand Down Expand Up @@ -348,6 +349,9 @@ static int __init pxa25x_init(void)
clks_register(&pxa25x_hwuart_clk, 1);

if (cpu_is_pxa21x() || cpu_is_pxa25x()) {

reset_status = RCSR;

clks_register(pxa25x_clks, ARRAY_SIZE(pxa25x_clks));

if ((ret = pxa_init_dma(16)))
Expand Down
4 changes: 4 additions & 0 deletions arch/arm/mach-pxa/pxa27x.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <asm/arch/pxa-regs.h>
#include <asm/arch/pxa2xx-regs.h>
#include <asm/arch/mfp-pxa27x.h>
#include <asm/arch/reset.h>
#include <asm/arch/ohci.h>
#include <asm/arch/pm.h>
#include <asm/arch/dma.h>
Expand Down Expand Up @@ -384,6 +385,9 @@ static int __init pxa27x_init(void)
int i, ret = 0;

if (cpu_is_pxa27x()) {

reset_status = RCSR;

clks_register(pxa27x_clks, ARRAY_SIZE(pxa27x_clks));

if ((ret = pxa_init_dma(32)))
Expand Down
9 changes: 9 additions & 0 deletions arch/arm/mach-pxa/pxa2xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,19 @@
#include <linux/kernel.h>
#include <linux/device.h>

#include <asm/hardware.h>
#include <asm/arch/pxa2xx-regs.h>
#include <asm/arch/mfp-pxa2xx.h>
#include <asm/arch/mfp-pxa25x.h>
#include <asm/arch/reset.h>
#include <asm/arch/irda.h>

void pxa2xx_clear_reset_status(unsigned int mask)
{
/* RESET_STATUS_* has a 1:1 mapping with RCSR */
RCSR = mask;
}

static unsigned long pxa2xx_mfp_fir[] = {
GPIO46_FICP_RXD,
GPIO47_FICP_TXD,
Expand Down
10 changes: 10 additions & 0 deletions arch/arm/mach-pxa/pxa3xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

#include <asm/hardware.h>
#include <asm/arch/pxa3xx-regs.h>
#include <asm/arch/reset.h>
#include <asm/arch/ohci.h>
#include <asm/arch/pm.h>
#include <asm/arch/dma.h>
Expand Down Expand Up @@ -109,6 +110,12 @@ unsigned int pxa3xx_get_memclk_frequency_10khz(void)
return (clk / 10000);
}

void pxa3xx_clear_reset_status(unsigned int mask)
{
/* RESET_STATUS_* has a 1:1 mapping with ARSR */
ARSR = mask;
}

/*
* Return the current AC97 clock frequency.
*/
Expand Down Expand Up @@ -532,6 +539,9 @@ static int __init pxa3xx_init(void)
int i, ret = 0;

if (cpu_is_pxa3xx()) {

reset_status = ARSR;

/*
* clear RDH bit every time after reset
*
Expand Down
7 changes: 4 additions & 3 deletions arch/arm/mach-pxa/reset.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@
#include <asm/proc-fns.h>

#include <asm/arch/pxa-regs.h>
#include <asm/arch/pxa2xx-regs.h>
#include <asm/arch/reset.h>

unsigned int reset_status;
EXPORT_SYMBOL(reset_status);

static void do_hw_reset(void);

static int reset_gpio = -1;
Expand Down Expand Up @@ -78,8 +80,7 @@ static void do_hw_reset(void)

void arch_reset(char mode)
{
if (cpu_is_pxa2xx())
RCSR = RCSR_HWR | RCSR_WDR | RCSR_SMR | RCSR_GPR;
clear_reset_status(RESET_STATUS_ALL);

switch (mode) {
case 's':
Expand Down
3 changes: 3 additions & 0 deletions arch/arm/mach-sa1100/generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@

#include "generic.h"

unsigned int reset_status;
EXPORT_SYMBOL(reset_status);

#define NR_FREQS 16

/*
Expand Down
9 changes: 9 additions & 0 deletions include/asm-arm/arch-pxa/reset.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
#ifndef __ASM_ARCH_RESET_H
#define __ASM_ARCH_RESET_H

#define RESET_STATUS_HARDWARE (1 << 0) /* Hardware Reset */
#define RESET_STATUS_WATCHDOG (1 << 1) /* Watchdog Reset */
#define RESET_STATUS_LOWPOWER (1 << 2) /* Low Power/Sleep Exit */
#define RESET_STATUS_GPIO (1 << 3) /* GPIO Reset */
#define RESET_STATUS_ALL (0xf)

extern unsigned int reset_status;
extern void clear_reset_status(unsigned int mask);

/*
* register GPIO as reset generator
*/
Expand Down
18 changes: 18 additions & 0 deletions include/asm-arm/arch-sa1100/reset.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#ifndef __ASM_ARCH_RESET_H
#define __ASM_ARCH_RESET_H

#include "hardware.h"

#define RESET_STATUS_HARDWARE (1 << 0) /* Hardware Reset */
#define RESET_STATUS_WATCHDOG (1 << 1) /* Watchdog Reset */
#define RESET_STATUS_LOWPOWER (1 << 2) /* Exit from Low Power/Sleep */
#define RESET_STATUS_GPIO (1 << 3) /* GPIO Reset */
#define RESET_STATUS_ALL (0xf)

extern unsigned int reset_status;
static inline void clear_reset_status(unsigned int mask)
{
RCSR = mask;
}

#endif /* __ASM_ARCH_RESET_H */

0 comments on commit 04fef22

Please sign in to comment.