Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] wa-sqlite support #3

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] wa-sqlite support #3

wants to merge 5 commits into from

Conversation

rkistner
Copy link
Contributor

@rkistner rkistner commented Aug 27, 2024

This is experimental, and not quite ready yet. It does however demonstrate how wa-sqlite could be supported in principle, despite having a very different API from better-sqlite3 and node:sqlite.

Some remaining issues:

  • Currently requires hacking & breaking existing tests, e.g. removing the logic to delete databases.
  • Currently only supports an in-memory database.
  • Error handling is not properly implemented yet - the tests report unhandled errors.
  • This uses an outdated fork of wa-sqlite. It should be updated to wa-sqlite 1.x.

Additionally, adding worker management options would be great, and even better if it could re-use NodeJS worker_thread code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant