-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: PowerSync encryption with SQLCipher #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Package refactoring and cleanup
rkistner
reviewed
Oct 18, 2024
stevensJourney
previously approved these changes
Oct 23, 2024
Closed
rkistner
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The melos.yml version
-> preCommit
command needs to be updated - the version.dart file has moved.
Co-authored-by: Ralf Kistner <ralf@journeyapps.com>
rkistner
previously approved these changes
Nov 12, 2024
- powersync@1.10.0 - powersync_core@1.0.0 - powersync_sqlcipher@0.1.0 - powersync_attachments_helper@0.6.16
rkistner
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables the use of database encryption with SQLCipher. It also includes a refactor into two new packages,
powersync_core
(Dart only) andpowersync_sqlcipher
in order to achieve this.powersync_core
includes all of the originalpowersync
setup and functionality and exports it for the other packages to use.powersync_core
is now used bypowersync
which is a thin package that depends onsqlite3_flutter_libs
for Flutter projectspowersync_core
is also used bypowersync_sqlcipher
which is a thin package that depends onsqlcipher_flutter_libs
.powersync_attachments_helper
also depends onpowersync_core
for its basic functionality.The reason for this refactor is so that we can make
PowerSync
compatible with both Dart and Flutter apps. It also allows us to enable encryption for users who can now install and importpowersync_sqlcipher
. Finally, it maintains the original PowerSync API for users usingpowersync
.TODO