fix: represent latency as empty string in csv printer failed probes (#…

…276) * fix: represent latency as empty string in csv printer failed probes * Update csv.go * Update csv.go * Update csv.go
pouriyajamshidi · Dec 25, 2024 · e9d88d9 · e9d88d9
1 parent 10c8639
commit e9d88d9
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/csv.go b/csv.go
@@ -141,9 +141,6 @@ func (cp *csvPrinter) printStart(hostname string, port uint16) {
 
 func (cp *csvPrinter) printProbeSuccess(localAddr string, userInput userInput, streak uint, rtt float32) {
 	hostname := userInput.hostname
-	if hostname == "" {
-		hostname = "-"
-	}
 
 	record := []string{
 		"Reply",
@@ -165,17 +162,18 @@ func (cp *csvPrinter) printProbeSuccess(localAddr string, userInput userInput, s
 
 func (cp *csvPrinter) printProbeFail(userInput userInput, streak uint) {
 	hostname := userInput.hostname
-	if hostname == "" {
-		hostname = "-"
-	}
 
 	record := []string{
 		"No reply",
 		hostname,
 		userInput.ip.String(),
 		fmt.Sprint(userInput.port),
 		fmt.Sprint(streak),
-		"-",
+		"",
+	}
+
+	if *cp.showLocalAddress {
+		record = append(record, "")
 	}
 
 	if err := cp.writeRecord(record); err != nil {
@@ -187,10 +185,10 @@ func (cp *csvPrinter) printRetryingToResolve(hostname string) {
 	record := []string{
 		"Resolving",
 		hostname,
-		"-",
-		"-",
-		"-",
-		"-",
+		"",
+		"",
+		"",
+		"",
 	}
 
 	if err := cp.writeRecord(record); err != nil {
@@ -203,7 +201,7 @@ func (cp *csvPrinter) printError(format string, args ...any) {
 }
 
 func (cp *csvPrinter) writeStatsHeader() error {
-    
+
 	headers := []string{
 		"Metric",
 		"Value",