Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created model blueprint #90

Closed

Conversation

mattmarcum
Copy link
Contributor

I use the ember-cli model blueprint as basis so we don't reinvent the wheel. The file template uses ember-pouch's model class.

I use the  ember-cli model blueprint as basis so we don't reinvent the wheel.  The file template uses ember-pouch's model class.
@mattmarcum mattmarcum changed the title Created basic model blueprint Created model blueprint Sep 6, 2015
@rsutphin
Copy link
Collaborator

rsutphin commented Dec 5, 2015

This looks good to me. Can you provide an example of how to use it in the README? (Sorry for the slow response.)

@nolanlawson
Copy link
Member

Ditto, would like an explanation of what this PR is doing. (Not too familiar with Ember blueprints.)

@mattmarcum
Copy link
Contributor Author

I updated the README with a section for blueprints and for this model blueprint. I also added the section for my application adapter pr...so depending on the order of merging there will be a conflict.

Here's ember-cli's section on blueprints: http://ember-cli.com/extending/#generators-and-blueprints

@fsmanuel
Copy link
Collaborator

fsmanuel commented Dec 8, 2015

I don't think it's a good idea to use ember g model modelName but I'm not an active ember-pouch user. What if I use ember-pouch for some models but have default ember-data models as well?

As I said I'm not an active ember-pouch user so you might know better.

@rsutphin
Copy link
Collaborator

Thanks for the change, @mattmarcum. I didn't realize this was taking the plain "model" blueprint name — for some reason I thought it would be automatically namespaced by ember-cli. What do you think about pouch-model as the blueprint name instead? (Dasherized seems like the standard for ember-cli generators.)

If you agree, could you make that change and then rebase/squash? Thanks.

@mattmarcum
Copy link
Contributor Author

closing in favor of #101

@mattmarcum mattmarcum closed this Dec 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants