Move blueprint files into explicit directories #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using __path__ meant the adapter file was generated at /app/pouch-adapters/__name__.js, for instance. Ember Data was not finding it, nor the models stored within pouch-models.
|
Yeah, sorry originally when I made the blueprints they were named model/adapter and everything worked...but a name change was requested and I forgot to change the paths...good catch |
|
Agreed that we should take this as a solution for now — if someone's using pods and can assist getting them to work there also that would be great. |
rsutphin
added a commit
that referenced
this pull request
Dec 20, 2015
Move blueprint files into explicit directories
rsutphin
added a commit
that referenced
this pull request
Dec 20, 2015
simonexmachina
added a commit
to jtribe/ember-pouch
that referenced
this pull request
Aug 17, 2016
* upstream/master: (32 commits) fixing readme reference to config key, concerning adapter blueprint. 3.2.1 Fix(Addon): Call super in init 3.2.0 Add relationship documentation Update README.md update readme update readme 3.1.1 (pouchdb-community#16) - Add override so serialiser saves hasMany Pouch adapter now calls a hook method when encountering a change for a record that is not yet loaded. update readme 3.1.0 Fix version check for Ember Data 3.2.x Update changelog for pouchdb-community#103 Tests for existing change watcher behavior Factor out integration test setup into module helper Move blueprint files into explicit directories Changelog for pouchdb-community#101 and pouchdb-community#102. created blueprint for pouch-adapter ...
simonexmachina
added a commit
to jtribe/ember-pouch
that referenced
this pull request
Aug 17, 2016
* upstream/master: (32 commits) fixing readme reference to config key, concerning adapter blueprint. 3.2.1 Fix(Addon): Call super in init 3.2.0 Add relationship documentation Update README.md update readme update readme 3.1.1 (pouchdb-community#16) - Add override so serialiser saves hasMany Pouch adapter now calls a hook method when encountering a change for a record that is not yet loaded. update readme 3.1.0 Fix version check for Ember Data 3.2.x Update changelog for pouchdb-community#103 Tests for existing change watcher behavior Factor out integration test setup into module helper Move blueprint files into explicit directories Changelog for pouchdb-community#101 and pouchdb-community#102. created blueprint for pouch-adapter ...
simonexmachina
added a commit
to jtribe/ember-pouch
that referenced
this pull request
Aug 17, 2016
* upstream/master: (32 commits) fixing readme reference to config key, concerning adapter blueprint. 3.2.1 Fix(Addon): Call super in init 3.2.0 Add relationship documentation Update README.md update readme update readme 3.1.1 (pouchdb-community#16) - Add override so serialiser saves hasMany Pouch adapter now calls a hook method when encountering a change for a record that is not yet loaded. update readme 3.1.0 Fix version check for Ember Data 3.2.x Update changelog for pouchdb-community#103 Tests for existing change watcher behavior Factor out integration test setup into module helper Move blueprint files into explicit directories Changelog for pouchdb-community#101 and pouchdb-community#102. created blueprint for pouch-adapter ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just started a new
ember-pouchapplication and used thepouch-modelandpouch-adapterblueprints. They use the__path__directory name:So when I ran
ember g pouch-adapter application, it generated the adapter at/app/pouch-adapters/application. Likewiseember g pouch-model destinationcreated/app/pouch-models/destination.js. Then Ember Data couldn’t find them!I’m not sure whether this is the full solution because I know the
__path__thing is involved in pods. But without pods, the way it’s generating files is broken!