feat(loaders): thrown navigation results take precedence

src/data-fetching_new/navigation-guard.spec.ts

@@ -377,6 +377,7 @@ describe('navigation-guard', () => {
       await vi.runOnlyPendingTimersAsync()
       l1.resolve(new NavigationResult('/#ok'))
       await router.getPendingNavigation()
+      expect(selectNavigationResult).toHaveBeenCalledTimes(1)
       expect(router.currentRoute.value.fullPath).toBe('/#ok')
     })
 
@@ -429,5 +430,26 @@ describe('navigation-guard', () => {
       await router.getPendingNavigation()
       expect(router.currentRoute.value.fullPath).toBe('/fetch')
     })
+
+    it('immediately stops if a NavigationResult is thrown instead of returned inside the loader', async () => {
+      const router = getRouter()
+      const l1 = mockedLoader()
+      router.addRoute({
+        name: '_test',
+        path: '/fetch',
+        component,
+        meta: {
+          loaders: [l1.loader],
+        },
+      })
+
+      router.push('/fetch')
+      await vi.runOnlyPendingTimersAsync()
+      const r1 = new NavigationResult('/#ok')
+      l1.reject(r1)
+      await router.getPendingNavigation().catch(() => {})
+      expect(selectNavigationResult).not.toHaveBeenCalled()
+      expect(router.currentRoute.value.fullPath).toBe('/#ok')
+    })
   })
 })

src/data-fetching_new/navigation-guard.ts

@@ -187,7 +187,14 @@ export function setupLoaderGuard({
           return selectNavigationResult(to.meta[NAVIGATION_RESULTS_KEY]!)
         }
       })
-    // no catch so errors are propagated to the router
+      .catch((error) =>
+        error instanceof NavigationResult
+          ? error.value
+          : // let the error propagate to router.onError()
+            // we use never because the rejection means we never resolve a value and using anything else
+            // will not be valid from the navigation guard's perspective
+            Promise.reject<never>(error)
+      )
   })
 
   // listen to duplicated navigation failures to reset the pendingTo and pendingLoad