-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sandbox to work with collection variables by exposing collectionVariables
in execution
#217
Conversation
type: 'string' | ||
}, { | ||
key: 'var3', | ||
value: 'collection-var3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason for skipping the type
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, I threw in some of these randomly to make sure legacy variables work
|
||
// can set variables with same keys as collectionVariables | ||
assert.strictEqual(pm.variables.get('var3', undefined)); | ||
assert.strictEqual(pm.variables.set('var3', 'hola')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have accidentally removed var3
from context, adding it back now. Good spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nitpicks, the rest looks alright.
@kunagpal addressed your comments 🙂 |
No description provided.