[POA-2781] Implement pods health checker #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgritter
approved these changes
Feb 10, 2025
| for podName, podStatus := range podStatuses { | ||
| if podStatus == string(coreV1.PodSucceeded) || podStatus == string(coreV1.PodFailed) { | ||
| printer.Infof("pod %s has stopped running", podStatus) | ||
| d.StopApiDumpProcess( |
There was a problem hiding this comment.
This adds an additional case where concurrency may occur in StopApiDumpProcess; we may learn about a stopped pod nearly-simultaneously from this worker and from the event channel. I think that is manageable, but it has to be considered.
…-pods-health-check-worker
mudit-postman
merged commit 87c6814
into
mudit/poa-2780-http-client-changes
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we have added a worker which will keep on check the status for pods for which we are running pidump process