Fixed unable to validate schema with type: array #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijitkane
reviewed
Apr 8, 2020
lib/deref.js
Outdated
| @@ -20,6 +20,11 @@ const _ = require('lodash'), | |||
| PARAMETER_SOURCE = { | |||
| REQUEST: 'REQUEST', | |||
| RESPONSE: 'RESPONSE' | |||
| }, | |||
| // Specifies type of Resolving of Refs that can be performed | |||
| RESOLVE_REFS_FOR = { | |||
There was a problem hiding this comment.
this seems incorrectly named
the validation/conversion should be in a different enum - PROCESSING_TYPE, for example
lib/schemaUtils.js
Outdated
| @@ -64,6 +64,11 @@ const async = require('async'), | |||
| RESPONSE_HEADER: 'response header', | |||
| RESPONSE_BODY: 'response body' | |||
| }, | |||
| // Specifies types of Resolving of Refs that can be performed | |||
| RESOLVE_REFS_FOR = { | |||
There was a problem hiding this comment.
this enum should only be defined in one place
lib/deref.js
Outdated
| // This nonsense is needed because the schemaFaker doesn't respect options.maxItems/minItems | ||
| schema.maxItems = 2; | ||
| schema.minItems = 2; | ||
| // Set minItems and maxItems property as 2 for CONVERSION |
There was a problem hiding this comment.
also explain why
I can tell that you're setting max/min to 2 for conversion. The comment should explain why you're not doing that for validation
…TYPE and added decriptive comment for setting minItems and maxItems properties to 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : postmanlabs/postman-app-support#8098
Bug was happening due to always overriding
minItemsandmaxItemsproperties to 2 for type: array inderef.resolveRefs().Added support for Resolving refs for CONVERSION/VALIDATION in
deref.resolveRefs()function.