-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage of util.inherits()
is discouraged.
#2908
base: develop
Are you sure you want to change the base?
Conversation
Hi @shamasis , I think codecov status is stuck should i try adding new commits to trigger codecov report again ? |
Codecov Report
@@ Coverage Diff @@
## develop #2908 +/- ##
===========================================
+ Coverage 90.96% 91.03% +0.07%
===========================================
Files 21 21
Lines 1151 1149 -2
Branches 349 349
===========================================
- Hits 1047 1046 -1
+ Misses 104 103 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
It's not deprecated, just legacy which means that it's okay if you use it. You can see the differences in https://nodejs.org/api/documentation.html#stability-index. The reason why it's marked legacy is that it doesn't establish the prototype chain as described in nodejs/node#4179 but it works pretty well in most cases. Is this patch aiming to solve a problem we are facing with the usage of |
util.inherits()
is deprecated and should be avoided to use.see https://nodejs.org/api/util.html#utilinheritsconstructor-superconstructor