fix: locals in inherited layout

posthtml · Dec 2, 2021 · 4f33548 · 4f33548
1 parent b74c2d0
commit 4f33548
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -47,12 +47,13 @@ function handleExtendsNodes(tree, options, messages) {
         locals = JSON.parse(extendsNode.attrs.locals);
       } catch {}
     }
-    options.expressions.locals = merge(options.expressions.locals, locals);
-    options.plugins.push(expressions(options.expressions));
+
+    var options_expressions = merge(options.expressions, {locals});
+    var plugins = [...options.plugins, expressions(options_expressions)];
 
     const layoutPath = path.resolve(options.root, extendsNode.attrs.src);
     const layoutHtml = fs.readFileSync(layoutPath, options.encoding);
-    const layoutTree = handleExtendsNodes(applyPluginsToTree(parseToPostHtml(layoutHtml), options.plugins), options, messages);
+    const layoutTree = handleExtendsNodes(applyPluginsToTree(parseToPostHtml(layoutHtml), plugins), options, messages);
 
     extendsNode.tag = false;
     extendsNode.content = mergeExtendsAndLayout(layoutTree, extendsNode, options.strict, options.slotTagName, options.fillTagName);

diff --git a/test/extend.js b/test/extend.js
@@ -154,6 +154,42 @@ describe('Extend', () => {
     });
   });
 
+  it('should accept locals in inherited layout', () => {
+    mfs.writeFileSync('./parent.html', `
+          <div class="parent">
+            <span>{{ parent_var }}</span>
+            <block name="content"></block>
+          </div>
+        `);
+
+    mfs.writeFileSync('./child.html', `
+            <div class="child">
+              <span>{{ child_var }}</span>
+              <block name="child_content"></block>
+            </div>
+        `);
+
+    return init(`
+            <extends src="parent.html" locals='{"parent_var":"parent var sample"}'>
+              <block name="content">
+                <extends src="child.html" locals='{"child_var":"child var sample"}'>
+                  <block name="child_content">child content example</block>
+                </extends>
+              </block>
+            </extends>
+        `, {strict: false}).then(html => {
+      expect(html).toBe(cleanHtml(`
+            <div class="parent">
+            <span>parent var sample</span>
+            <div class="child">
+              <span>child var sample</span>
+              child content example
+            </div>
+            </div>
+            `));
+    });
+  });
+
   it('should extend inherited layout', () => {
     mfs.writeFileSync('./base.html', `
             <html>