Require a reason when marking a server bad #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecharmon
force-pushed
the
648-log-errors-server-bad
branch
from
fdafbc0
to
f08d44c
Compare
|
The change is welcome, let me know when it compiles and passes our test suite, and I'll be happy to review and merge. |
When calling mark_bad require a reason so it can be logged rather than the generic message
alecharmon
force-pushed
the
648-log-errors-server-bad
branch
from
f08d44c
to
b48a6fe
Compare
|
@levkk thanks! I am getting transient test errors on my last couple runs, is there a chance the tests are flaking? |
|
Definitely possible that some tests are flakey. If it fails consisitently though, there is an issue. |
|
I relaunched the job, let's see if it passes this time. The code looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling mark_bad require a reason so it can be logged rather than
the generic message. Relates to #648