Removed unnecessary clippy overrides.
#614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh awesome thanks. Sorry, didn't mean to go review your draft, I just randomly stumbled on your PR in my notifications and saw the clippy stuff. Back in the day I used to work with Rubocop (Ruby) and it had the same issues: it linted very well, but in the end of the day people started putting all kinds of exceptions everywhere because some code just had to look a certain way. So our code ended up being 80% code and 20% Rubocop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two unnecessary
clippyoverrides that are removed in this PR.