Reset instead of discard all #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zainkabani
commented
Aug 16, 2023
| @@ -821,6 +821,14 @@ where | |||
| message_result = read_message(&mut self.read) => message_result? | |||
| }; | |||
|
|
|||
| if message[0] as char == 'X' { | |||
There was a problem hiding this comment.
A previous PR had moved the admin handling to before the message code match, an admin client disconnect produces an error log so this moves the 'X' message code check to before the admin client handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCARD ALL can destroy any prepared statements on a server which is not something we want when using prepared statement mode. Instead we can be more precise in our cleanup steps and RESET all settings using the RESET ALL command, and DEALLOCATE ALL only when a prepare is sent