Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle and track startup parameters #478

Merged
merged 22 commits into from
Aug 10, 2023

Conversation

zainkabani
Copy link
Contributor

@zainkabani zainkabani commented Jun 16, 2023

This PR helps to track startup and other other parameter status packets during the lifetime of client and server connections.

The set of tracked parameters is from pgbouncer. When a client checks out a server connection, it compares the server_parameters that are stored on the client (desired) and on the server. If there's a difference it will send set statements to synchronize the parameters.

@zainkabani zainkabani marked this pull request as ready for review June 17, 2023 19:45
src/server.rs Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/client.rs Show resolved Hide resolved
Copy link
Contributor

@levkk levkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@levkk levkk merged commit f94ce97 into postgresml:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants