Avoid reporting ProtocolSyncError when admin session disconnects #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! CI error looks like a flake. |
jmeagher
pushed a commit
to jmeagher/pgcat
that referenced
this pull request
Feb 17, 2023
Avoid reporting ProtocolSyncError when admin session disconnects (postgresml#160) Better logging for failure to get connection from pool (postgresml#161) Send signal even if process is gone (postgresml#162) Clean connection state up after protocol named prepared statement (postgresml#163) Add Discord link (postgresml#164) Add SHOW CLIENTS / SHOW SERVERS + Stats refactor and tests (postgresml#159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We report
ProtocolSyncErrorif we hit the admin handler codepath with any message other thanQ. When we moved theXpacket handling to happen with the extended protocol packets, we introduced a bug where we will reportProtocolSyncErrorevery time admin client disconnects.This PR fixes this