PGgeo-PGgeometry-PGgeography class hierarchy #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postgis#55 - Renamed test in postgis-geometry test suite - Introduced new JDBC PGobject extensions class hierarchy which now allows jdbc queries to return geometry or geography data with specific types which callers can use to differentiate which data type was queried - Cleanup and better documentation for DriverWrapper - Renamed AutoRegistrationTest to DatatypesAutoRegistration to better reflect what is being tested - Added geography as one of the castTypes in the EmptyGeometriesTest class - Added instantiation test for PGgeography to DatatypesTest class - Added GeographyDatatypeTest to verify new PGgeo/PGgeometry/PGgeography class hierarchy - Added PGgeography to driverconfig.properties
wouterh-dev
reviewed
May 4, 2021
|
|
||
| /** {@inheritDoc} */ | ||
| @Override | ||
| public void addGeometries(final Connection conn) throws SQLException { |
There was a problem hiding this comment.
Is there a reason that geography is mapped to PGgeometry instead of PGgeography in this method, unlike the other methods?
There was a problem hiding this comment.
I don't immediately see a reason why. It looks like an oversight in the refactoring.
It also looks like the mappings might be missing a mapping for geography that is not qualified by a schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#55
Renamed test in postgis-geometry test suite
Introduced new JDBC PGobject extensions class hierarchy which now allows jdbc queries to return geometry or geography data with specific types which callers can use to differentiate which data type was queried
Cleanup and better documentation for DriverWrapper
Renamed AutoRegistrationTest to DatatypesAutoRegistration to better reflect what is being tested
Added geography as one of the castTypes in the EmptyGeometriesTest class
Added instantiation test for PGgeography to DatatypesTest class
Added GeographyDatatypeTest to verify new PGgeo/PGgeometry/PGgeography class hierarchy
Added PGgeography to driverconfig.properties