Ignore CSS custom properties in color(<color>) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should be something more generic that just send a message using postcss message api, not just related to var. If a resolution fail, we should throw a warning not just throw a fatal. |
|
Ok, so instead of just skipping |
|
I guess :) |
Exceptions are thrown by `css-color-function` when processing an invalid value. This change catches those exceptions and turns them into postcss warnings. --- Add postcss message when color function contains a var() Custom properties cannot be resolved by `css-color-function`. This change skips color functions that contain `var(` and adds a message to the postcss `result.messages` with type 'skipped-color-function-with-custom-property'.
drewbourne
force-pushed
the
ignore-custom-properties
branch
from
dceb8bd to
717a9f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4 by skipping any
colorfunctions that contain avar