Support mkdirp to create dest path if it doesn't exists #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| fs.statSync(name); | ||
| } catch (e) { | ||
| mkdirp.sync(path.dirname(name)); | ||
| } |
There was a problem hiding this comment.
You can do better
mkdirp(path.dirname(name), function (err) {
if (err) {
fn(err);
} else {
fs.writeFile(name, content, fn);
}
});There was a problem hiding this comment.
I mean even without precheck with fs.stat
There was a problem hiding this comment.
Seems nice! Let me update it to the above you wrote.
There was a problem hiding this comment.
Thanks for your comment! Updated codes like you said @TrySound
|
Can you provide test case? |
|
Isn't this test I added enough to cover this patch? Makefile#L95-L97 |
|
Oh, okay. Didn't understand it's test. |
|
Yeah actually we can rewrite tests to js from |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15