Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle summands that cancel out and pull out common factors #114

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Sep 1, 2020

Closes #107

  1. Only remove the something in (expr + something) +- (expr - something) if it's actually addition and subtraction that cancel out.
  2. Pull out common factors in (expr * something) +- (expr * something) (for var expressions [Bug] : css nano strips away important factors from multiplications in calc()  #107 (comment) )

Copy link
Collaborator

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@alexander-akait
Copy link
Collaborator

@Semigradsky Can you do release? Don't have time on this right now 😞

@Semigradsky Semigradsky merged commit 9807c5e into postcss:master Sep 1, 2020
@Semigradsky
Copy link
Member

No probs

@Semigradsky
Copy link
Member

@mischnic
Copy link
Contributor Author

mischnic commented Sep 1, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] : css nano strips away important factors from multiplications in calc()
3 participants