fix: unitless zero for <angle> values are allowed in CSS gradients
#1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yisibl
commented
Sep 20, 2022
| background: -webkit-linear-gradient(bottom, green, blue); | ||
| background: -o-linear-gradient(bottom, green, blue); | ||
| background: linear-gradient(0grad, green, blue); | ||
| background-image: -webkit-repeating-linear-gradient(bottom, blue, red 33.3%); |
There was a problem hiding this comment.
I don't know why the test failed here, the single test(test.only('changes angle in gradient') was passed.
There was a problem hiding this comment.
It was prefixes cleaning test which failed.
Seems like we forgot to think about cleaning repeating gradients when we added their support.
Here is my fix 542bd85
|
Thanks. Released in 10.4.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems found during lightningcss discussion: parcel-bundler/lightningcss#298