Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some effects don't update when their controllers value changes #173

Closed
ChrisAdderley opened this issue Oct 8, 2024 · 3 comments
Closed

Some effects don't update when their controllers value changes #173

ChrisAdderley opened this issue Oct 8, 2024 · 3 comments
Labels
bug Something isn't working next release Done, coming in next release

Comments

@ChrisAdderley
Copy link
Collaborator

From: https://forum.kerbalspaceprogram.com/topic/196309-112x-waterfall-a-framework-for-continuous-mesh-driven-engine-effects-october-6/?do=findComment&comment=4425210

Confirmed to happen with same modlist/test path. Some effects update, some do not.
@ChrisAdderley ChrisAdderley added the bug Something isn't working label Oct 8, 2024
@ChrisAdderley
Copy link
Collaborator Author

Seems to happen in flight sometimes too.

@ChrisAdderley ChrisAdderley changed the title Editor: Some effects don't update when their controllers are overridden in the UI Editor: Some effects don't update when their controllers value changes Oct 8, 2024
@ChrisAdderley ChrisAdderley changed the title Editor: Some effects don't update when their controllers value changes Some effects don't update when their controllers value changes Oct 8, 2024
@ChrisAdderley
Copy link
Collaborator Author

Additional examples
https://github.com/CobaltWolf/Bluedog-Design-Bureau/blob/master/Gamedata/Bluedog_DB/Compatibility/WaterfallFX/Templates/BDB_RS68_ablative.cfg
https://github.com/CobaltWolf/Bluedog-Design-Bureau/blob/master/Gamedata/Bluedog_DB/Compatibility/WaterfallFX/Templates/BDB_F1_film.cfg
image

JonnyOThan added a commit to JonnyOThan/Waterfall that referenced this issue Oct 9, 2024
@JonnyOThan
fix post-kerbin-mining-corporation#173: integrators could fail to rep…
ac1a05a 
…ort as active when inputs don't change

-this would then treat the transform as disabled so other integrators wouldn't run on it
ChrisAdderley added a commit that referenced this issue Oct 9, 2024
@ChrisAdderley
Merge pull request #175 from JonnyOThan/fix-effect-integrator
a67ddcb 
fix #173: integrators could fail to report as active when inputs don't change
@ChrisAdderley ChrisAdderley added the next release Done, coming in next release label Oct 9, 2024
@ChrisAdderley
Copy link
Collaborator Author

Fix released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working next release Done, coming in next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisAdderley