Improve messaging of "took too long" message #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the text of the message when we fail to connect to the Shiny app to say
where we previously said
which makes it sounds like Shiny didn't open the browser rather than "we're not going to open the preview".
Also while here I realized we could use progress bar incrementing to give a sense of how long we'll wait before giving up.
Kapture.2024-08-28.at.08.13.04.mp4
cc @karangattu
btw, @jcheng5 the example above shows why I changed the default wait back to 10s in #74. Notice that the Shiny app never starts in the clip. We can't detect this automatically, we have to wait for the app launch to timeout. So we now wait 10s the first time and 30s thereafter if the user says it's okay to keep waiting.