Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use {cli} for console printing #104

Merged
merged 6 commits into from
Jul 5, 2024
Merged

feat: Use {cli} for console printing #104

merged 6 commits into from
Jul 5, 2024

Conversation

gadenbuie
Copy link
Contributor

  • Use cli for command line printing
  • cli functions are called through wrappers that respect the shinylive.quiet global option and no-op if quiet = TRUE.
  • export(verbose=) is deprecated in favor of quiet
  • assets_info() gains a quiet argument
  • Overly verbose file-copying messages are now suppressed in export().

@gadenbuie gadenbuie requested a review from schloerke July 2, 2024 17:01
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Just a cosmetic change to move verbose= (which is already after the ...) to the end so users are less tempted.

R/export.R Outdated Show resolved Hide resolved
@gadenbuie gadenbuie added this to the v0.2.0 milestone Jul 3, 2024
@gadenbuie gadenbuie merged commit 415ef5a into main Jul 5, 2024
12 checks passed
@gadenbuie gadenbuie deleted the feat/cli branch July 5, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants