Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version to 1.23.1 #2270

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Update go version to 1.23.1 #2270

merged 3 commits into from
Sep 18, 2024

Conversation

dotNomad
Copy link
Collaborator

@dotNomad dotNomad commented Sep 12, 2024

Used

go mod edit -go=1.23.1

Intent

Resolves #2268

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Copy link
Collaborator

@sagerb sagerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a concern regarding what was lost in the upgrade. Do we need to worry?

go.mod Outdated Show resolved Hide resolved
go.sum Show resolved Hide resolved
@dotNomad
Copy link
Collaborator Author

Had a concern regarding what was lost in the upgrade.

I re-did this commit without the go tidy so the indirect requires should no longer be removed.

@dotNomad
Copy link
Collaborator Author

Immediately got an error when trying to build with just the version upgrade:

go: updates to go.mod needed, disabled by -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
	to update it:
	go mod tidy

So re-added the go mod tidy.

@mmarchetti would you mind taking a look, and letting me know if I'm missing something in our Go version upgrade flow?

@mmarchetti
Copy link
Collaborator

go mod tidy removes what it thinks are unused packages. We're overriding the version of protobuf because github.com/spf13/afero's go.mod depends on a vulnerable version. This isn't the first vulnerable dependency afero has, and hasn't mitigated (there have only been 2 PRs merged this year in that repo). We might consider seeing if there's a fork that is better maintained, or fork it ourselves and updated the dependencies there.

@dotNomad
Copy link
Collaborator Author

Updated with a commit from @mmarchetti that updated the go.mod off of main and ran go mod vendor

Copy link
Collaborator

@sagerb sagerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded to go 1.23.1 within VSCode and build runs successfully.

@dotNomad dotNomad merged commit b7c6d0e into main Sep 18, 2024
13 checks passed
@dotNomad dotNomad deleted the dotnomad/go-up branch September 18, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to go 1.23.1
3 participants