Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Select dropdown for UI Tests #2123

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Conversation

kgartland-rstudio
Copy link
Collaborator

Intent

This PR uses the new Select dropdown for our UI tests. Note: Windows will continue to fail due to these fantasticon issues:
tancredi/fantasticon#528
tancredi/fantasticon#470
tancredi/fantasticon#471

We may need to downgrade fantasticon to 1.2.3 to fix those issues.

Copy link
Collaborator

@sagerb sagerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Happy this didn't take too long to adjust w/ the change.

@kgartland-rstudio kgartland-rstudio merged commit 8b50df1 into main Aug 16, 2024
13 checks passed
@kgartland-rstudio kgartland-rstudio deleted the kg-use-new-select branch August 16, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants