Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable update checks and allow auto-updates #6194

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

timtmok
Copy link
Contributor

@timtmok timtmok commented Jan 31, 2025

Release Notes

Address #1837

Enables update checking by default. The update service will respect the update mode setting. When an update is discovered, an action is available for the user to download the update.

image

An auto-update option is shown for Mac and Windows users that is off by default. Turning on auto-updates will check the pre-releases for a new version. This will update Positron in the background.

If auto-update is enabled in dev, it disables updates. The check has been moved later in the initialization so that the logs can show the preferences were set. Disabling auto-update will allow update checks for testing.

When auto-updates off, the download update action links to the file update instead of the Positron site. This ensures the correct update is downloaded in case there is a lag with updating the website download links. The Positron website has also been added to the trusted links.

New Features

  • Releases: Positron should check for updates #1837 Update checking is enabled by default. There are preferences for setting when updates are checked or to turn it off. A preference for auto-updates has been added to Mac and Windows that is disabled by default. Turning it on allows Positron to immediately download the update.

Bug Fixes

  • N/A

QA Notes

Add option to enable auto-updates
Only allow auto-updates on windows and mac
@timtmok timtmok requested a review from jmcphers January 31, 2025 17:03
Copy link

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

Copy link
Collaborator

@jmcphers jmcphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will be great to have this turned on!

@timtmok timtmok merged commit afaf9bf into main Feb 5, 2025
8 checks passed
@timtmok timtmok deleted the feature/enable-update-checks branch February 5, 2025 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants