Support language keyboard shortcuts in Quarto chunks #1955
Comments
|
Currently our rules for the pipe shortcut say positron/extensions/positron-r/package.json Lines 32 to 36 in de7666b I don't know what Quarto currently gives us for Just to link these up, we are tracking some other related issues about Quarto and language features: |
|
Some research ... I just created a new Quarto document in positron and added an R chunk. With the cursor inside that chunk, I inspected context keys. https://code.visualstudio.com/api/references/when-clause-contexts#inspect-context-keys-utility 
|
|
This came up during usability testing with @gadenbuie today, and is a reason he shies away from using Quarto in Positron and/or VS Code. |
|
This came up in our private beta here: https://github.com/posit-dev/positron-beta/discussions/90 Should we do something easy and quick in the short term, like add the pipe shortcut to the RStudio keymap? |
|
After #3523 we have the shortcuts for |
|
In the source mode it currently works like a charm! However, as noted in #4368, it still doesn't work in the visual mode |
|
Quick hack around: modify the shortcuts directly (change when expression) to |
Thank you for your suggestion! I tried your proposed solution but sadly it didn't work for me (in the source mode it works as before, but in visual mode nothing happens) |
Addresses #1955 together with quarto-dev/quarto#608 The Quarto PR provides new context keys for the main language of a Quarto document (for example, R or Python) and we can consume those to provide keyboard shortcuts. There are really only a couple of R ones that we want right now which means that there is no real change here in an R `.qmd` in behavior compared to what is in the RStudio Keymap. 🙈 However, I think this is still worth getting in since we've gone to the trouble of figuring it out, it lets us offer these without the RStudio Keymap being on, we can offer them _only_ in R `.qmd` files (right now, these also show up in Python `.qmd` files if you have the RStudio Keymap on), and we can use this infrastructure in the future. I did remove these from the RStudio Keymap just to clean things up, but it wouldn't hurt _a lot_ to keep them, if there is some reason I am not thinking of? If we do want to remove them, we'll need to do a Quarto release and update the bundled Quarto VS Code extension version in this PR to keep these keybindings functional. ### QA Notes With the new version of the Quarto extension (updated here), you can use the keyboard shortcuts for the pipe and assignment operator in R Quarto documents but not Python ones: - <kbd>Alt</kbd>+<kbd>-</kbd> to get you `<-` - <kbd>Cmd/Ctrl</kbd>+<kbd>Shift</kbd>+<kbd>M</kbd> to get you `|>`
Verified FixedPositron Version(s) : 2024.12.0-96 Test scenario(s)Keyboard shortcuts now work in Quarto document as expected. Link(s) to TestRail test cases run or created: |
With an open R file,
cmd+shift+mwill automatically insert R pipe (|>). However, in an R code chunk within a Quarto document, the same shortcut instead opens thePROBLEMSpanel. The VS Code keyboard shorcuts doc indicates that this is the expected behavior for this keybinding in VS Code:However, it feels like Quarto chunks should prioritize language-specific key bindings. I intentionally left this issue title a bit vague in case there are other bindings that don't function as expected from within quarto chunks.
The text was updated successfully, but these errors were encountered: