Introduce httptest for API mocking; update to testthat 3e #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration test failures say the license has expired: https://github.com/rstudio/connectapi/actions/runs/8571214328/job/23490961358?pr=223#step:7:28 @colearendt @aronatkins can we fix this? |
I do not have sufficient rights. It'll have to be @colearendt. |
nealrichardson
force-pushed
the
httptest
branch
from
54617f9 to
fea06d9
Compare
|
Integration tests are running now that this is rebased on main, but now they're failing, I'm guessing it has to do with testthat 3e. I'll fix. |
nealrichardson
force-pushed
the
httptest
branch
2 times, most recently
from
b691659 to
22ab78a
Compare
nealrichardson
changed the title
…fix bug in error message
…to remove this This reverts commit b691659.
nealrichardson
force-pushed
the
httptest
branch
from
9ebcf72 to
b1c4dcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds https://enpiar.com/r/httptest/ for testing the API client with mock/recorded API responses. This allows contributors to run tests for the R code without having to run a local Connect server, which is not an option for most. I'd like to get some good overall coverage of the package's behaviors before doing any refactoring, just so we have some confidence that we aren't breaking things.
Before this PR, the line coverage of the non-integration tests was 15%. I've added some basic tests for Content, Permissions, and Users, pulling in the fixtures from posit-sdk-py. This gets coverage up to 24%. Followup PRs can extend this approach to get more coverage.
I avoided making changes in the package itself, though I did fix a bug in an error message builder, one broken API doc link, and I added
Config/testthat/edition: 3to the DESCRIPTION, both of which triggered some autoformatting.I also removed the
mockerydependency, as it was only being used in one test that could be rewritten to use a mock request.