Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #212

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix typo #212

merged 1 commit into from
Feb 26, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Feb 14, 2024

just to make sure it doesn't fall through the cracks.

@aronatkins aronatkins requested a review from hadley February 16, 2024 14:42
@aronatkins
Copy link
Contributor

@hadley - this will probably need to be pulled into a branch (not fork) until we have a CI answer for forks.

@hadley
Copy link
Contributor

hadley commented Feb 20, 2024

@aronatkins yeah, I wish there was some way to do that more easily. But in this case, I don't think we need to worry since it will only be triggered in the case where dbplyr is not installed, which I don't think any of our builds cover. But we could add a mocked test if you wanted.

@aronatkins aronatkins merged commit 2fa4ee7 into posit-dev:main Feb 26, 2024
9 of 12 checks passed
@olivroy olivroy deleted the patch-2 branch February 26, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants