Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.14 #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hjkatz
Copy link

@hjkatz hjkatz commented Mar 1, 2020

No description provided.

@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #14 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   79.31%   79.31%           
=======================================
  Files           2        2           
  Lines          29       29           
=======================================
  Hits           23       23           
  Misses          5        5           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b1603...30aeae5. Read the comment docs.

@posener
Copy link
Owner

posener commented Mar 2, 2020

Hi,
What command exactly did you run in order to make this change, and why is it useful?
Thanks!

@hjkatz
Copy link
Author

hjkatz commented Mar 2, 2020

@posener I have go 1.14 installed. I changed go.mod from go 1.12 to go 1.14 and ran go build which then updated the go.mod and go.sum for me. Pretty easy to me :D

@posener
Copy link
Owner

posener commented Mar 2, 2020

Strange... why did it update all the dependencies? I can't reproduce it...

$ go version
go version go1.14 linux/amd64
$ git diff
diff --git a/go.mod b/go.mod
index 68b8d0c..25cb015 100644
--- a/go.mod
+++ b/go.mod
@@ -1,5 +1,5 @@
 module github.com/posener/ctxutil
 
-go 1.12
+go 1.14
 
 require github.com/stretchr/testify v1.3.0
$ go build ./...
$ go test ./...
PASS
ok  	github.com/posener/ctxutil	0.505s

Diff remains the same.

@hjkatz
Copy link
Author

hjkatz commented Mar 2, 2020

Hmmm... to be 100% honest I'm not sure. What I think may have happened is that I have "update go build" or something turned on in my "vim-go" profile, and maybe internal to that the go.mod file was updated?

If you'd prefer we can not merge this PR. It's a precursor to some work I'm doing on my branch here. Which I'll submit sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants