Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pb-4322: Fix issue in updating the large kdmp job LastKnownError to volumebackup CR status. #303

Merged
merged 1 commit into from
Aug 30, 2023
Merged

pb-4322: Fix issue in updating the large kdmp job LastKnownError to volumebackup CR status. #303

merged 1 commit into from
Aug 30, 2023

Conversation

siva-portworx
Copy link
Contributor

What this PR does / why we need it:

pb-4322: Fix issue in updating the large kdmp job LastKnownError to
    volumebackup CR status.

            - Some time, the kdmp job LastKnownError are very large and
              exceeds th etcd large request size of 1.5M.
            - So avoid the update of kdmp job LastKnownError in volumebackup
              CR status and dump them in job pod log

Which issue(s) this PR fixes (optional)
Closes # pb-4322

Special notes for your reviewer:

pb-4322: Fix issue in updating the large kdmp job LastKnownError to
a930fb3 
volumebackup CR status.

	- Some time, the kdmp job LastKnownError are very large and
	  exceeds th etcd large request size of 1.5M.
	- So avoid the update of kdmp job LastKnownError in volumebackup
	  CR status and dump them in job pod log
@github-actions
Copy link

OSS Scan Results:

Title Severity Package Name CVEs Fix version Introduced

Total issues: 0

@github-actions
Copy link

License Evaluation Results:

Title Package Name Package Version Severity License Info Introduced
MPL-2.0 license github.com/hashicorp/errwrap 1.1.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume/portworx@#72cf75320066', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#72cf75320066', 'github.com/hashicorp/go-multierror@1.1.1', 'github.com/hashicorp/errwrap@1.1.0']
MPL-2.0 license github.com/hashicorp/go-multierror 1.1.1 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume/portworx@#72cf75320066', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#72cf75320066', 'github.com/hashicorp/go-multierror@1.1.1']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume/portworx@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/pkg/k8sutils@#72cf75320066', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/pkg/resourcecollector@#72cf75320066', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume/csi@#72cf75320066', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume@#72cf75320066', 'github.com/libopenstorage/stork/pkg/k8sutils@#72cf75320066', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume/aws@#72cf75320066', 'github.com/libopenstorage/stork/pkg/k8sutils@#72cf75320066', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume/azure@#72cf75320066', 'github.com/libopenstorage/stork/pkg/k8sutils@#72cf75320066', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#72cf75320066', 'github.com/libopenstorage/stork/pkg/k8sutils@#72cf75320066', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume/gcp@#72cf75320066', 'github.com/libopenstorage/stork/pkg/k8sutils@#72cf75320066', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume/portworx@#72cf75320066', 'github.com/libopenstorage/stork/pkg/snapshot/controllers@#72cf75320066', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/pkg/snapshotter@#72cf75320066', 'github.com/libopenstorage/stork/pkg/k8sutils@#72cf75320066', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
MPL-2.0 license github.com/hashicorp/go-version 1.6.0 medium MPL-2.0 ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#72cf75320066', 'github.com/libopenstorage/stork/drivers/volume/kdmp@#72cf75320066', 'github.com/libopenstorage/stork/pkg/k8sutils@#72cf75320066', 'github.com/libopenstorage/stork/pkg/version@#72cf75320066', 'github.com/hashicorp/go-version@1.6.0']
Unknown license github.com/portworx/kdmp 0.0.0 high Unknown ['github.com/portworx/kdmp@0.0.0']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#72cf75320066', 'github.com/libopenstorage/stork/pkg/platform/rancher@#72cf75320066', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/name@1.1.0']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume/csi@#72cf75320066', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#72cf75320066', 'github.com/libopenstorage/stork/pkg/platform/rancher@#72cf75320066', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/name@1.1.0']
Unknown license github.com/rancher/wrangler/pkg/name 1.1.0 high Unknown ['github.com/portworx/kdmp@0.0.0', 'github.com/libopenstorage/stork/drivers/volume/portworx@#72cf75320066', 'github.com/libopenstorage/stork/pkg/applicationmanager/controllers@#72cf75320066', 'github.com/libopenstorage/stork/pkg/platform/rancher@#72cf75320066', 'github.com/rancher/rancher/pkg/client/generated/management/v3@#a67566517525', 'github.com/rancher/norman/types@#275a3e921940', 'github.com/rancher/wrangler/pkg/name@1.1.0']

Total License Issues: 20

@siva-portworx siva-portworx merged commit 704706d into master Aug 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityadani adityadani adityadani approved these changes

@lalat-das lalat-das Awaiting requested review from lalat-das

@diptiranjanpx diptiranjanpx Awaiting requested review from diptiranjanpx

@prashanthpx prashanthpx Awaiting requested review from prashanthpx

@px-kesavan px-kesavan Awaiting requested review from px-kesavan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siva-portworx @adityadani