WIP: Spout implementation #1
Conversation
src/SpoutReader.php
Outdated
| */ | ||
| public function __construct(\SplFileObject $file, $headerRowNumber = null, $activeSheet = null, $shouldPreserveEmptyRows = true) | ||
| { | ||
| $reader = $this->createReaderForFile($file, $shouldPreserveEmptyRows); |
There was a problem hiding this comment.
I would rather inject the ReaderInterface directly.
There was a problem hiding this comment.
Fixed, the user must call the ReaderInterface::open method before use the SpoutReader
There was a problem hiding this comment.
With this fix, the SpoutReader is compatible with CSV, XLSX and ODS.
But the method count of the ODS format throw an exception because the RowIterator can't be rewind more than once. See https://github.com/box/spout/blob/3681a3421a868ab9a65da156c554f756541f452b/src/Spout/Reader/ODS/RowIterator.php#L101
Maybe, I will not implement the CountableReader interface
| */ | ||
| public function setHeaderRowNumber($rowNumber) | ||
| { | ||
| $rowNumber = (int) $rowNumber; |
There was a problem hiding this comment.
I would rather use a static type hint for this method.
src/SpoutReader.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| public function getRow($number) |
There was a problem hiding this comment.
Removed
I have added it because the ExcelReader implement it https://github.com/portphp/excel/blob/458d5cf105206f6391e4350ee095110d18eda090/src/ExcelReader.php#L201
composer.json
Outdated
| @@ -23,16 +23,17 @@ | |||
| "docs": "http://docs.portphp.org" | |||
| }, | |||
| "require": { | |||
| "php": ">=5.4.0" | |||
| "php": ">=5.5.0", | |||
There was a problem hiding this comment.
We should require at least php 5.6, because portphp/portphp requires at least php 5.6.
I tried to implement the
spoutreader and writer.Spoutread and write spreadsheet files in CSV, XLSX and ODS. But, the reader is only compatible with XLSX.I based myself on the code of
portphp/excel, the fixtures are XLS format butspoutdoesn't manage this format. I converted the XLS file in XLSX format withlibreofficeThe writer can't edit an existing spreadsheet, the data will be overwritten.
http://opensource.box.com/spout/guides/add-data-to-existing-spreadsheet/
http://opensource.box.com/spout/guides/edit-existing-spreadsheet/
Close portphp/portphp#61