Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix read data of display #2312

Merged
merged 1 commit into from
Oct 19, 2024
Merged

fix read data of display #2312

merged 1 commit into from
Oct 19, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Oct 19, 2024 •
edited
Loading

UNDARKENED_PIXEL is a misleading naming, it should be like BRIGHTEN or somethings
but let's keep it as it was since it's not my code

@zxkmm zxkmm marked this pull request as ready for review October 19, 2024 12:20
gullradriel
gullradriel approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gullradriel gullradriel merged commit 7a38b04 into portapack-mayhem:next Oct 19, 2024
3 checks passed
@zxkmm zxkmm deleted the fix_shiftback branch October 20, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gullradriel gullradriel gullradriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxkmm @gullradriel