Selectable 314.9 vs 315MHz TPMS RX freq #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
htotoo
pushed a commit
to htotoo/portapack-mayhem
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow selection between 314.9 vs 315.0 MHz TPMS receive frequency, per suggestion in issue #2242
I don't know why this should be necessary since the bandwidth is set to 1.75MHz, but it doesn't hurt. In my own testing a 314.9 MHz pressure sensor shows up regardless whether RX frequency is set to 314.9 or 315.0.
This PR also helps with a past concern whether we should display "433" vs "434" for 433.92 MHz; now the display will show "433.9" vs "434". (Sorry there isn't room for the full 433.92)
(A test version is attached to issue #2242)