-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pmem reset #1115
Pmem reset #1115
Conversation
it still need to be tripple checked if adc or control init really doesnt use any pmem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the stuff we talked about in discord
Its ready. Now left+right key held down together ignores the pmem at boot. I was thinking and choose a combination that cannot be accidentally triggered. Also the hardware selection keys are only active during boot when theres only one key pressed, so it wont interfere with any double key trigger in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the Test -drive binary , that has combined Debut and this Reset pmem.
I could confirm , that the freq, volume , AMP , VGA, and other user settings (splash , LCD timer , add return GUI key , becomes
reset to default values when keeping pressing LEFT - RIGTH when booting .
I checked , when using pmem , and it works well -
(But when Pmem Mgnt is set up to SD card, I can not see that reset , ex. freq , VGA, AMP, ...
maybe intentionally . )
Anyway considering pmem, (not SD card, that has his separate reset option) , To me it is checked and approved .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work getting this all fixed,
Guauuuuu @u-foka , thanks a lot !!!! From fw version 1.5.4 onwards , it was introduced that PR #662 that uses the persistent memory to test and store the hardware and LCD config settings, from that point , when reflashing binaries compiled from (gcc-arm ... version 9.3) --> to my local (gcc -arm.version 10.3) , But thanks to that PR, I will no need to use the intermediate 1.4.3, anymore ! Thanks a lot @u-foka , this PR , gave me tools to reset the persistent memory and solve that nasty problem |
Ignore pmem contents during startup if the select key is being held down.
This could solve boot hangups that typically happen after flashing.
Checked and compatible with hardware selection keys.
If one wants to both select (or keep selecting) a hw version, while ignoring pmem both the right direction and select keys has to be held down.