Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pmem reset #1115

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Pmem reset #1115

merged 3 commits into from
Jun 7, 2023

Conversation

u-foka
Copy link
Contributor

@u-foka u-foka commented Jun 6, 2023

Ignore pmem contents during startup if the select key is being held down.
This could solve boot hangups that typically happen after flashing.
Checked and compatible with hardware selection keys.
If one wants to both select (or keep selecting) a hw version, while ignoring pmem both the right direction and select keys has to be held down.

u-foka added 2 commits June 6, 2023 23:53
it still need to be tripple checked if adc or control init really doesnt use any pmem
@u-foka u-foka marked this pull request as draft June 6, 2023 22:04
Copy link
Contributor

@jLynx jLynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the stuff we talked about in discord

@u-foka u-foka marked this pull request as ready for review June 7, 2023 18:35
@u-foka
Copy link
Contributor Author

u-foka commented Jun 7, 2023

Its ready.

Now left+right key held down together ignores the pmem at boot. I was thinking and choose a combination that cannot be accidentally triggered.

Also the hardware selection keys are only active during boot when theres only one key pressed, so it wont interfere with any double key trigger in the future.

Copy link
Contributor

@Brumi-2021 Brumi-2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the Test -drive binary , that has combined Debut and this Reset pmem.
I could confirm , that the freq, volume , AMP , VGA, and other user settings (splash , LCD timer , add return GUI key , becomes
reset to default values when keeping pressing LEFT - RIGTH when booting .
I checked , when using pmem , and it works well -
(But when Pmem Mgnt is set up to SD card, I can not see that reset , ex. freq , VGA, AMP, ...
maybe intentionally . )
Anyway considering pmem, (not SD card, that has his separate reset option) , To me it is checked and approved .

Copy link
Contributor

@jLynx jLynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work getting this all fixed,

@jLynx jLynx merged commit 3ddc753 into portapack-mayhem:next Jun 7, 2023
@u-foka u-foka deleted the pmem-reset branch June 8, 2023 09:47
@Brumi-2021
Copy link
Contributor

Brumi-2021 commented Jun 8, 2023

Guauuuuu @u-foka , thanks a lot !!!!
That PR , fixed completelly my local problem ,

From fw version 1.5.4 onwards , it was introduced that PR #662 that uses the persistent memory to test and store the hardware and LCD config settings, from that point , when reflashing binaries compiled

from (gcc-arm ... version 9.3) --> to my local (gcc -arm.version 10.3) ,
In my case,changing any binary created from 9-3 ---> 10.3 , I always got incorrect boot, just flashing the top LED's ...
And to solve it , I always need to reflash to a very old one fw ,ex. 1.4.3 ( (prior to the sharebrained commit about persistence memory ) and from that fw version , I can reflash without any problem to any fw created with my local compilation gcc-10.3

But thanks to that PR, I will no need to use the intermediate 1.4.3, anymore !
I tested now , I got again wrong BOOT , with top LED , flashing , but switching off and switching on pressing LEFT / RIGHT , voilà , solved completely , and having a correct boot.

Thanks a lot @u-foka , this PR , gave me tools to reset the persistent memory and solve that nasty problem
👏👏👏👌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants