Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle delete events from change log where there is no after #73

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Handle delete events from change log where there is no after #73

merged 4 commits into from
Aug 16, 2023

Conversation

Tankilevitch
Copy link
Contributor

Description

What - Handle where the integration receive an event of deletion from the port's Kafka
Why -
How - Check whether there is after

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)

yairsimantov20
yairsimantov20 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@yairsimantov20 yairsimantov20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊 LGTM

@Tankilevitch Tankilevitch merged commit a8dfb17 into main Aug 16, 2023
1 check passed
@Tankilevitch Tankilevitch deleted the handle-delete-events-when-there-is-no-after branch August 16, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairsimantov20 yairsimantov20 yairsimantov20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tankilevitch @yairsimantov20