Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional webhook #71

Merged
merged 5 commits into from
Aug 11, 2023
Merged

optional webhook #71

merged 5 commits into from
Aug 11, 2023

Conversation

yairsimantov20
Copy link
Collaborator

Description

What - the app host is failing the integration to start if not set
Why - the property is required and sometimes the gitlab does not have a webhook for the groups in gitlab
How - made it so the feature is optional

Type of change

  • Non-breaking change (fix of existing functionality that will not change current behavior)

Copy link
Member

@MPTG94 MPTG94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

integrations/gitlab/gitlab_integration/ocean.py Outdated Show resolved Hide resolved
@yairsimantov20 yairsimantov20 merged commit f646e93 into main Aug 11, 2023
1 check passed
@yairsimantov20 yairsimantov20 deleted the gitlab-optional-webhook branch August 11, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants