Add Azure integration #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-azure-integration-powered-by-ocean
…-azure-integration-powered-by-ocean
yairsimantov20
approved these changes
Aug 17, 2023
integrations/azure/.port/spec.yaml
Outdated
Comment on lines
9
to
11
| - kind: resource_group | ||
| - kind: container_app | ||
| - kind: aks |
There was a problem hiding this comment.
You don't really know all the possibilities
So i think it will be better to delete this field
| current_resource_kind, is_last_level = get_resource_kind_by_level( | ||
| full_resource_kind, kind_level | ||
| ) | ||
| current_resource_kind_suffix = current_resource_kind.split("/")[-1] |
There was a problem hiding this comment.
_*, var_name = iter
There was a problem hiding this comment.
I think it is more readable with -1 , but if it is a convention you want to have let me know and i'll update
…-azure-integration-powered-by-ocean
….com:port-labs/Port-Ocean into PORT-4351-azure-integration-powered-by-ocean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port 4351
What - Add azure integration as well as default deployment method using terraform over azure
Why -
How -
Microsoft.Storage/storageAccounts/blobServices/containerswhich is an extension resource ofMicrosoft.Storage/storageAccounts.Type of change
Please leave one option from the following and delete the rest:
TODOs