Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 6993 ocean allow async calls in the jq entity processor #403

Conversation

yairsimantov20
Copy link
Collaborator

@yairsimantov20 yairsimantov20 commented Mar 3, 2024

Description

What - Right now we cant run async logic from within the jq entities processor
Why - The functions are sync
How - changed the functions to be async & applied an async wrap for the jq

Type of change

  • New feature (non-breaking change which adds functionality)

@github-actions github-actions bot added framework A change in the ocean framework files size/M labels Mar 3, 2024
Copy link
Collaborator

@danielsinai danielsinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! :)

@yairsimantov20 yairsimantov20 merged commit 2676ad5 into main Mar 3, 2024
4 checks passed
@yairsimantov20 yairsimantov20 deleted the PORT-6993-ocean-allow-async-calls-in-the-jq-entity-processor branch March 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework A change in the ocean framework files size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants