PORT-4337 Improved error PortClient handling #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvirsegev
approved these changes
Jul 25, 2023
phalbert
added a commit
that referenced
this pull request
Oct 7, 2024
# Description - Added a new kind `stage` - Added a new blueprint `jenkinsStage` ### Implementation Utilized the Jenkins API provided by the [pipeline-stage-view-plugin](https://github.com/jenkinsci/pipeline-stage-view-plugin/tree/master/rest-api#get-jobjob-namewfapiruns) to retrieve pipeline stage information. The API returns details such as stage IDs, names, statuses, start times, durations, and links to each stage, as shown in the example JSON response below: ```json { "_links": { "self": { "href": "/job/Phalbert/job/airframe-react/job/master/29/wfapi/describe" } }, "id": "29", "name": "#29", "status": "FAILED", "startTimeMillis": 1717069181870, "endTimeMillis": 1717070384780, "durationMillis": 1202910, "queueDurationMillis": 5, "pauseDurationMillis": 0, "stages": [ { "_links": { "self": { "href": "/job/Phalbert/job/airframe-react/job/master/29/execution/node/6/wfapi/describe" } }, "id": "6", "name": "Declarative: Checkout SCM", "execNode": "", "status": "SUCCESS", "startTimeMillis": 1717070383791, "durationMillis": 892, "pauseDurationMillis": 0 }, { "_links": { "self": { "href": "/job/Phalbert/job/airframe-react/job/master/29/execution/node/17/wfapi/describe" } }, "id": "17", "name": "Declarative: Post Actions", "execNode": "", "status": "SUCCESS", "startTimeMillis": 1717070384739, "durationMillis": 24, "pauseDurationMillis": 0 } ] } ``` Additional Context: For more details and ongoing discussion, please refer to the linked Slack thread: [Jira Task Discussion](https://getport.slack.com/archives/C0799SR843F/p1723749916041039). ## Type of change Please leave one option from the following and delete the rest: - [x] New feature (non-breaking change which adds functionality) <h4> All tests should be run against the port production environment(using a testing org). </h4> ### Core testing checklist - [ ] Integration able to create all default resources from scratch - [ ] Resync finishes successfully - [ ] Resync able to create entities - [ ] Resync able to update entities - [ ] Resync able to detect and delete entities - [ ] Scheduled resync able to abort existing resync and start a new one - [ ] Tested with at least 2 integrations from scratch - [ ] Tested with Kafka and Polling event listeners ### Integration testing checklist - [x] Integration able to create all default resources from scratch - [x] Resync able to create entities - [x] Resync able to update entities - [x] Resync able to detect and delete entities - [x] Resync finishes successfully - [x] If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the `examples` folder in the integration directory. - [x] If resource kind is updated, run the integration with the example data and check if the expected result is achieved - [x] If new resource kind is added or updated, validate that live-events for that resource are working as expected - [x] Docs PR link [here](port-labs/port-docs#1613) ### Preflight checklist - [x] Handled rate limiting - [x] Handled pagination - [x] Implemented the code in async - [ ] Support Multi account ## Screenshots Include screenshots from your environment showing how the resources of the integration will look. ## API Documentation Provide links to the API documentation used for this integration. --------- Co-authored-by: PagesCoffy <isaac.p.coffie@gmail.com> Co-authored-by: omby8888 <160610297+omby8888@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Some of the PortClient request errors dont show the error message
How - normalized the way to handle the http response
Type of change