[Integration][GitLab] Fix few bugs #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
changed the title
yairsimantov20
approved these changes
Nov 7, 2023
| Project, | ||
| ] | ||
| ], | ||
| [Any], |
There was a problem hiding this comment.
Can you open a task on me to fix this typing?
There was a problem hiding this comment.
I'm pretty sure this is the correct typing though.
The paging shouldn't care what the validation function it gets; Each validation function should define whatever parameters it wants, Shouldn't it?
pazhersh
approved these changes
Nov 7, 2023
| Project, | ||
| ] | ||
| ], | ||
| [Any], |
There was a problem hiding this comment.
I'm pretty sure this is the correct typing though.
The paging shouldn't care what the validation function it gets; Each validation function should define whatever parameters it wants, Shouldn't it?
…Ocean into PORT-fix-gitlab-exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
file://is configured inport.ymlType of change
Please leave one option from the following and delete the rest: