[Core] Added base_url to core

[matan84]

User description

Description

What - Added a new base_url variable to core

Why - allow us to deprecate the app_host usage and to standardize naming to core

How - added new variable to ocean config

Type of change

Please leave one option from the following and delete the rest:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• New Integration (non-breaking change which adds a new integration)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Non-breaking change (fix of existing functionality that will not change current behavior)
• Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

• Integration able to create all default resources from scratch
• Resync finishes successfully
• Resync able to create entities
• Resync able to update entities
• Resync able to detect and delete entities
• Scheduled resync able to abort existing resync and start a new one
• Tested with at least 2 integrations from scratch
• Tested with Kafka and Polling event listeners
• Tested deletion of entities that don't pass the selector

Integration testing checklist

• Integration able to create all default resources from scratch
• Resync able to create entities
• Resync able to update entities
• Resync able to detect and delete entities
• Resync finishes successfully
• If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
• If resource kind is updated, run the integration with the example data and check if the expected result is achieved
• If new resource kind is added or updated, validate that live-events for that resource are working as expected
• Docs PR link here

Preflight checklist

• Handled rate limiting
• Handled pagination
• Implemented the code in async
• Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

---

PR Type

Enhancement

---

Description

• Introduced webhook_base_url to replace app_host.

• Added deprecation warning for app_host usage.

• Updated lifecycle logic to conditionally start webhook processing.

• Updated version and changelog to reflect changes.

---

Changes walkthrough 📝

	Relevant files
Enhancement	settings.py Added `webhook_base_url` configuration field                          port_ocean/config/settings.py Added webhook_base_url as a new configuration field. +1/-0      ocean.py Added `webhook_base_url` property and lifecycle updates    port_ocean/ocean.py Implemented webhook_base_url property with fallback to app_host. Added deprecation warning for app_host usage. Modified lifecycle to conditionally start webhook processing. +13/-1
Documentation	CHANGELOG.md Updated changelog for version 0.19.3                                          CHANGELOG.md Documented addition of webhook_base_url in version 0.19.3. +6/-0
Configuration changes	pyproject.toml Updated project version to 0.19.3                                                pyproject.toml Bumped version to 0.19.3. +1/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Error Handling The webhook_base_url property accesses dictionary values without proper error handling for missing keys or type mismatches if integration_config.get("app_host"): logger.warning( "The OCEAN__INTEGRATION__CONFIG__APP_HOST field is deprecated. Please use the OCEAN__WEBHOOK_BASE_URL field instead." ) return self.config.webhook_base_url or integration_config.get("app_host") Conditional Logic The webhook manager is only started if webhook_base_url exists, which could break existing functionality that depends on webhook processing if self.webhook_base_url: await self.webhook_manager.start_processing_event_messages()

[qodo-merge-pro]

Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Validate webhook URL format Add error handling for invalid webhook URLs to prevent runtime issues. Validate the URL format before using it. port_ocean/ocean.py [121-130] @property def webhook_base_url(self) -> str: integration_config = self.config.integration.config if isinstance(integration_config, BaseModel): integration_config = integration_config.dict() if integration_config.get("app_host"): logger.warning( "The OCEAN__INTEGRATION__CONFIG__APP_HOST field is deprecated. Please use the OCEAN__WEBHOOK_BASE_URL field instead." ) - return self.config.webhook_base_url or integration_config.get("app_host") + url = self.config.webhook_base_url or integration_config.get("app_host") + if url and not url.startswith(('http://', 'https://')): + raise ValueError(f"Invalid webhook URL format: {url}") + return url Apply this suggestion Suggestion importance[1-10]: 8 __ Why: The suggestion adds crucial URL validation to prevent runtime issues with malformed webhook URLs. This is important for system reliability and early error detection, as invalid URLs could cause failures in webhook processing.	Medium
Update

[aws-amplify-eu-west-1]

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1411.d1ftd8v2gowp8w.amplifyapp.com

[yaelibarg]