Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Adjust jq mapping log - terminology and counter #1291

Merged
merged 9 commits into from
Jan 2, 2025
Merged

[Core] Adjust jq mapping log - terminology and counter #1291

merged 9 commits into from
Jan 2, 2025

Conversation

No0b1t0
Copy link
Contributor

@No0b1t0 No0b1t0 commented Jan 2, 2025

Description

What -

  • Adjusted log teminology
  • Faild transformations counter increments for all cases (None (null / missing), empty)
    Why -
    the terminology of the log was not clear enough

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

@No0b1t0 No0b1t0 requested a review from a team January 2, 2025 12:31
@github-actions github-actions bot added size/S and removed size/XS labels Jan 2, 2025
matan84
matan84 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No0b1t0 and others added 2 commits January 2, 2025 04:39
@No0b1t0 @matan84
Update CHANGELOG.md
cc09bae 
Co-authored-by: Matan <51418643+matan84@users.noreply.github.com>
@No0b1t0 @matan84
Update CHANGELOG.md
00e5505 
Co-authored-by: Matan <51418643+matan84@users.noreply.github.com>
@No0b1t0 No0b1t0 merged commit 4223050 into main Jan 2, 2025
16 checks passed
@No0b1t0 No0b1t0 deleted the core-adjust-jq-mapping-log branch January 2, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matan84 matan84 matan84 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@No0b1t0 @matan84