Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port 4254 support port ocean in mypy #12

Merged
merged 8 commits into from
Jul 18, 2023
Merged

Port 4254 support port ocean in mypy #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4cc70d1
Added a py.typed file so that mypy will know to use our type annotati…
yairsimantov20 Jul 14, 2023
b849ed9
installing poetry using pip and excluding the venv from the mypy
yairsimantov20 Jul 14, 2023
ef492d7
bumped deps
yairsimantov20 Jul 14, 2023
74590f6
updated lock file
yairsimantov20 Jul 17, 2023
3487e47
removed -h
yairsimantov20 Jul 17, 2023
33a766a
Merge branch 'main' of github.com:port-labs/Port-Ocean into PORT-4254…
yairsimantov20 Jul 18, 2023
080f6b5
fixed lock file
yairsimantov20 Jul 18, 2023
d0433b3
fixed linting to match the integration linting
yairsimantov20 Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ACTIVATE := . .venv/bin/activate

define run_lint
define run_checks
exit_code=0; \
cd $1; \
poetry check || exit_code=$$?;\
Expand All @@ -9,18 +9,18 @@ define run_lint
ruff . || exit_code=$$?; \
black --check . || exit_code=$$?; \
if [ $$exit_code -eq 1 ]; then \
echo "\033[0;31mOne or more lints failed with exit code $$exit_code\033[0m"; \
echo "\033[0;31mOne or more checks failed with exit code $$exit_code\033[0m"; \
else \
echo "\033[0;32mAll lints executed successfully.\033[0m"; \
echo "\033[0;32mAll checks executed successfully.\033[0m"; \
fi; \
exit $$exit_code
endef


define install_poetry
if ! command -v poetry &> /dev/null; then \
echo "Poetry is not installed. Installing..."; \
curl -sSL https://install.python-poetry.org | python3 -; \
pip install --upgrade pip; \
pip install poetry; \
else \
echo "Poetry is already installed."; \
fi
Expand Down Expand Up @@ -67,7 +67,7 @@ install/all: install
# Linting
lint:
$(ACTIVATE) && \
$(call run_lint,.)
$(call run_checks,.)

lint/integrations:
$(ACTIVATE) && \
Expand Down
Loading