Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration][AWS] | Improved Concurrency Control and Eliminated Likelihood of Thundering Herd #1063

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mk-armah
Copy link
Member

@mk-armah mk-armah commented Oct 6, 2024

Description

What:

  • Refactored semaphore implementation to effectively limit concurrency across tasks.
  • Added a util semaphore_async_iterator to enable seamless control over concurrent executions per kind (can be re-used in other integrations).
  • Removed iterative calls to the cache for tracking token expiry, reducing the likelihood of a thundering herd problem.

Why:

  • The previous implementation limited concurrency within tasks (accounts), ideally, this use case requires concurrent limits is to be global, thus across accounts.
  • Iterative cache calls could potentially cause a thundering herd problem when cache expires and token needed to be refreshed.

How:

  • Applied the semaphore correctly by wrapping task creation with the semaphore, ensuring proper concurrency control.
  • Implemented unit tests using pytest to verify semaphore functionality and concurrency limits.
  • Optimized cache usage by eliminating unnecessary iterative calls for tracking expiry.

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

All tests should be run against the port production environment (using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping, and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

NB: Warning log in the screenshot below is just for demonstration purposes.
image

API Documentation

Provide links to the API documentation used for this integration.

@mk-armah mk-armah requested a review from a team as a code owner October 6, 2024 17:06
@github-actions github-actions bot added the size/L label Oct 6, 2024
@github-actions github-actions bot added size/M and removed size/L labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant