Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix overriding of next resync status when cancelled due to scheduled resync #1035

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

Tankilevitch
Copy link
Contributor

@Tankilevitch Tankilevitch commented Sep 19, 2024

Description

What - Fix overriding of next resync status when cancelled due to scheduled resync

Why - When setting up a low resync interval and the resync still runs, the new resync sends an abort signal to the existing integration causing it to stop, which then the integration updates the integration as completed, while the integration is actually running a resync, this causes incorrect status in the UI. In the case of having kafka configured it can also cause the integration to detect new resync.

How - Handled asyncio.CancelledError and skips updating the resync status.

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@Tankilevitch Tankilevitch requested a review from a team as a code owner September 19, 2024 16:29
@github-actions github-actions bot added size/L and removed size/XS labels Sep 20, 2024
@Tankilevitch Tankilevitch force-pushed the fix-overriding-of-next-resync-status branch from dd19227 to 58e0838 Compare September 20, 2024 04:19
@github-actions github-actions bot added size/XS and removed size/L labels Sep 20, 2024
@Tankilevitch Tankilevitch merged commit 236ae72 into main Sep 22, 2024
12 checks passed
@Tankilevitch Tankilevitch deleted the fix-overriding-of-next-resync-status branch September 22, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants